WIP: Safe transaction decoder #4800
Conversation
tkporter
requested review from
paulbalaji,
Mo-Hussain,
yorhodes,
jmrossy and
ltyu
as code owners
|
There was a problem hiding this comment.
surely you can read this via the api directly
There was a problem hiding this comment.
ha yeah it does do this, I'll remove this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4800 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 101 101
Lines 1481 1481
Branches 192 192
=======================================
Hits 1100 1100
Misses 360 360
Partials 21 21
|
| decoded.functionFragment, | ||
| ); | ||
| let prettyArgs = args; | ||
| if (decoded.functionFragment.name === 'enrollRemoteRouters') { |
There was a problem hiding this comment.
nit: can we import something that would avoid comparing to a literal?
|
Can you share some outputs please!! |
example outputs: |
|
Gonna move this to a draft |
Description
Drive-by changes
Related issues
Backward compatibility
Testing